pinba_engine icon indicating copy to clipboard operation
pinba_engine copied to clipboard

Make tag value's size configurable

Open nhatthm opened this issue 10 years ago • 2 comments

Hi, I have some features that need tags to be bigger than 65 bytes. Currently I forked your code and make it 255, then compiled and reinstalled

Can we make that value configurable? And what are the cons for that? From my side, I see only UDP buffer sizes will be impacted, it needs to be monitored and increased to prevent losing packets.

nhatthm avatar Jan 07 '15 09:01 nhatthm

You've just increased memory usage 4x for every tag. That might affect overall memory usage quite seriuosly when there are millions of timers with tags. I'll think about a way of making it configurable, but I can't think of any real need to send values this big. These are just tags, more or less unique identifiers, you really don't need to put whole poems in there. Let me guess, you just use Namespace+Class name+Method as your tags, right? :)

tony2001 avatar Jan 07 '15 09:01 tony2001

actually, i'm trying to track 404 and 503, and would like to add referrer and user-agent to understand why user reached that situation.

nhatthm avatar Jan 07 '15 09:01 nhatthm