Tomasz Wójcik

Results 47 comments of Tomasz Wójcik

> After reading the doc ( https://djoser.readthedocs.io/en/latest/settings.html#login-field) I found this setting an overkill feature. If django user model allows setting the login-field, overriding this with another layer while ignoring the...

Thank you @hisie for providing more info. After adding more context, I agree with everything you said. Lets continue the discussion in the PR.

The issue is that dependencies and middleware serve different purposes in FastAPI. Dependencies only exist during route handler execution and within the dependency's scope. Middlewares wraps the entire request-response cycle....

Thanks for creating the ticket, you're right. PRs welcome!

I have found some time to have a look into that. This integrity check should be implemented in the DB with a unique constraint. If such index existed, the create...

I closed the PR above as we can't justify an additional query to the DB to meet the criteria of a few. I will leave this ticket open. If someone...

Thanks for the report. Please create a failing test case.

Are there any plans to proceed with this PR? What are the next steps?

> @tomwojcik On Trac, issue has `Patch needs improvement` flag set. Removing it should push it to the review queue. I didn't know I have permissions to do that. Thanks...