Tom Moor

No red flags!

This is by design as attachments and images remain available in previous revisions of the document. We could definitely entertain some cleanup if the file is added AND removed before...

Yes! If we can get it going for email that should be a good foundation for the same diffing functionality in the app UI – I think it's very important.

Hey @haquezameer – sure thing, that would be great. In terms of order of operations, I'd focus on being able to display a visual diff between two document revisions first...

Yep, revisions are stored in the database. To reiterate, the real challenge here is rendering a nice looking diff between two markdown documents – you probably don't even need to...

It could be worth a try but I'm pretty sure that the diff implementation has to understand markdown, because If you change a heading from level 1 to level 2...

GitHub doesn't do a _great_ job of this, but it does what I'm saying – for example If I change a heading in the README of this project from level...

@haquezameer by all means, I do think there are a plenty of diffing algorithms already implemented in JS though, so that's also a route we could go

Hey, I believe this functionality will be covered by the work in https://github.com/outline/outline/pull/2388 as GitHub appears to be OpenID compatible

Returning to this – the amount of code here seems quite manageable, I'm not sure what kind of team would be using GitHub but not any of the other authentication...