typo
typo copied to clipboard
tomfran
A button for Light and Dark mode
It would be nice to have a button that allows you to actually switch between light and dark mode.
Yes I agree, need to find the right icon tho. I'll think of something
Might I suggest using these light and dark icons from Material Design? I've used them before and they are quite nice. Just search up "brightness", and you'll find some nice ones.
@tomfran You can check the icons on my website (https://neel04.github.io/my-website/) I've done a few changes to the colorscheme, but it'll fit right in to typo too I feel
Hey, I can take this one.
Only question is how should I configure the logic in the config? There's theme and colorPalette, and my intuition would be adding a colorPalette2 to the config and showing the mode button on the top right in case two palettes are different, to not to add more fields to the toml file.
Open for better ideas, did not think deep on it.
Here's a suggestion for the icons (let me know if you're looking for something much more aesthetic, this is just simple svg).
Hey, I can take this one.
Only question is how should I configure the logic in the config? There's
themeandcolorPalette, and my intuition would be adding acolorPalette2to the config and showing the mode button on the top right in case two palettes are different, to not to add more fields to the toml file.Open for better ideas, did not think deep on it.
Here's a suggestion for the icons (let me know if you're looking for something much more aesthetic, this is just simple svg).
I think ColorPallete 2 would be ok
Hey, I can take this one.
Only question is how should I configure the logic in the config? There's
themeandcolorPalette, and my intuition would be adding acolorPalette2to the config and showing the mode button on the top right in case two palettes are different, to not to add more fields to the toml file.Open for better ideas, did not think deep on it.
Hello @otaliptus and @Skrillx13, perhaps I didn't get your idea, but why are you thinking of a color palette 2? My idea would be to introduce a new "manual" theme mode, alongside the existing auto, light and dark. Perhaps we could specify what theme to use on the first visit, either dark or light.
The color palette stuff is independent, having two different palettes, one for light and one for dark respectively, wasn't contemplated. Also I feel this would complicate configuration, additionally, one can currently achieve this by defining a custom palette.
About the icons, yes those are really generic ones, but I guess we can always change them in the future/add a configuration for them.
Hey, I can take this one. Only question is how should I configure the logic in the config? There's
themeandcolorPalette, and my intuition would be adding acolorPalette2to the config and showing the mode button on the top right in case two palettes are different, to not to add more fields to the toml file. Open for better ideas, did not think deep on it.Hello @otaliptus and @Skrillx13, perhaps I didn't get your idea, but why are you thinking of a color palette 2? My idea would be to introduce a new "manual" theme mode, alongside the existing auto, light and dark. Perhaps we could specify what theme to use on the first visit, either dark or light.
The color palette stuff is independent, having two different palettes, one for light and one for dark respectively, wasn't contemplated. Also I feel this would complicate configuration, additionally, one can currently achieve this by defining a custom palette.
About the icons, yes those are really generic ones, but I guess we can always change them in the future/add a configuration for them.
I suppose that would work better. As for the icons, configuration could be added to allow the user to choose an icon from like an icon library.
Hi @tomfran have you managed to add a toggle for light/dark mode? Or maybe you have a workaround for now? Thank you
