ember-cli-addon-tests icon indicating copy to clipboard operation
ember-cli-addon-tests copied to clipboard

Add Yarn option

Open trentmwillis opened this issue 8 years ago • 3 comments
trafficstars

Fixes https://github.com/tomdale/ember-cli-addon-tests/issues/76. Provides a nice speed boost.

trentmwillis avatar May 25 '17 04:05 trentmwillis

LGTM, thanks for pushing this @trentmwillis!

Tests are failing however, yarn complains about some version mismatch. I have the suspicion that it behaves differently than npm, by checking the npm registry for our my-addon test addon, though the symlinked addon already exists. So it finds this interesting piece of software: https://www.npmjs.com/package/my-addon, whose only version is 0.0.1, as opposed to our symlinked 0.0.0! 😝

Maybe renaming my-addon to something more unique, like ember-cli-addon-tests-test-addon or whatever could be enough to fix the tests?

simonihmig avatar May 25 '17 12:05 simonihmig

@trentmwillis Just wondering, are you able to continue work on this? If you don't have time, maybe someone other can take this over? Would love to see this land...

Apart from the comments above and the failing test, there are now some merge conflicts that need to be addressed... (@kellyselden has been on fire lately 😉 )

simonihmig avatar Aug 08 '17 08:08 simonihmig

Yeah, sorry, I likely won't get to this any time soon, so if someone else would like to pick it up, go for it!

trentmwillis avatar Aug 08 '17 17:08 trentmwillis