crawler icon indicating copy to clipboard operation
crawler copied to clipboard

Published 20 hours ago • verified publisher icon tomasnorre

Suppress E_WARNING

Open ulrichmathes opened this issue 1 year ago • 1 comments
trafficstars

  • [BUGFIX] don't convert empty string
  • [BUGFIX] suppress unserialize E_WARNINGS

Description

Solves #1087

Prevents E_WANRINGS in JsonCompatibilityConverter by early return on empty strings and fixing the error handling of unserialize

I have

  • [x] Checked that CGL are followed
  • [x] Checked that the Tests are still working [unit, functional are not running in devbox?]
  • [x] Added description to CHANGELOG.md (github-handle is optional)
  • [ ] Added tests for the new code

ulrichmathes avatar Aug 07 '24 06:08 ulrichmathes

I don't understand how you get the E_WARNINGs that you want to remove with the "[BUGFIX] suppress unserialize E_WARNINGS" commit - the warning is caught by the try-catch block.

cweiske avatar Jan 17 '25 10:01 cweiske

@cweiske is this solved with https://github.com/tomasnorre/crawler/pull/1167 too?

tomasnorre avatar Sep 03 '25 09:09 tomasnorre

This can be closed. The issue is fixed with #1117 and #1167.

cweiske avatar Sep 03 '25 09:09 cweiske

Closed according to comment https://github.com/tomasnorre/crawler/pull/1091#issuecomment-3248351390

tomasnorre avatar Sep 03 '25 13:09 tomasnorre