crawler icon indicating copy to clipboard operation
crawler copied to clipboard

fix "crawler:buildQueue fails with Error at offset 0 of 92 bytes"

Open stephan-brun opened this issue 1 year ago • 1 comments
trafficstars

Fix #1087

stephan-brun avatar Jul 23 '24 14:07 stephan-brun

First, thanks a lot for providing the PR. To be honest. I have see this behavior before and tried to change the order of the if-checks, but gave other side effects. I don't recall from the top of my head, but some unwanted effects was present. I need to dig into this a little more again to validate the PR.

From a logical perspective, your check first sounds reasonable, as the converter is only there, is old data format is still present in queue, which shouldn't happen that often, only directly after an update.

So perhaps in Idea that I should consider implement, in the dev-main branch, as v11.x only get bugs fixes. Would be to make a command that updates the format ones, and remove the converter.

What do you think @stephan-brun @hacksch ?

tomasnorre avatar Jul 24 '24 14:07 tomasnorre

PR #1117 solves this problem in a non-intrusive way by only catching the E_WARNING.

cweiske avatar Jan 14 '25 12:01 cweiske

@tomasnorre you can close this PR; the problem has been solved with #1117. But please tag the latest v11.x branch commit.

cweiske avatar Jan 17 '25 10:01 cweiske

Resolved in #1117

tomasnorre avatar Jan 18 '25 08:01 tomasnorre