pull-request-notifier-for-bitbucket
pull-request-notifier-for-bitbucket copied to clipboard
Encrypt authentication credentials
Would it be possible to add encryption for the credentials? In the database lob_data, the credentials are stored as plain text. Thanks.
I would welcome it, but I don't know if its possible.
It would be nice also to hide or mask somehow credentials that are shown through the rest: rest/prnfb-admin/1.0/settings/notifications
Even if users can not modify these notifications they still can get credentials from global settings.
Couldn't you use something like this: http://bitwiseshiftleft.github.io/sjcl/
This issue is partly solved by now exposing credentials as string KEEP_THIS_TO_LEAVE_UNCHANGED. This means credentials are still stored in plain text in the database, but not exposed in the rest API.