pull-request-notifier-for-bitbucket icon indicating copy to clipboard operation
pull-request-notifier-for-bitbucket copied to clipboard

Escaping variables in URL

Open nucleusv opened this issue 6 years ago • 1 comments

We use multibranch in Jenkins, we trigger Jenkins from Bitbucket: URL for plugin https://smth.com/jenkins/job/${PULL_REQUEST_FROM_REPO_NAME}/job/${PULL_REQUEST_FROM_BRANCH}/buildWithParameters?${EVERYTHING_URL}

Which transforms in: "https://smth.com/jenkins/job/inninext-backend-message-router/job/feature%2Fpipeline-test/buildWithParameters?BUTTON_FORM_DATA=&BUTTON_TRIGGER_TITLE=&INJECTION_URL_VALUE=&PULL_REQUEST_ACTION=RESCOPED_FROM&PULL_REQUEST_AUTHOR_DISPLAY_NAME=Vadim+Nesterov&PULL_REQUEST_AUTHOR_EMAIL=vadim.nesterov%40powerhouse.nl&PULL_REQUEST_AUTHOR_ID=578&PULL_REQUEST_AUTHOR_NAME=vadim.nesterov%40powerhouse.nl&PULL_REQUEST_AUTHOR_SLUG=vadim.nesterov_powerhouse.nl&PULL_REQUEST_COMMENT_ACTION=&PULL_REQUEST_COMMENT_ID=

Branch name in Bitbuacket is: feature/pipeline-test URL of the job in Jenkins is: https://build.powerhouse.nl/jenkins/job/inninext-backend-message-router/job/feature%252Fpipeline-test/

As you see different escaping:

/jenkins/job/inninext-backend-message-router/job/feature%2Fpipeline-test/ /jenkins/job/inninext-backend-message-router/job/feature%252Fpipeline-test/

nucleusv avatar Dec 11 '18 12:12 nucleusv

feature%252Fpipeline-test decodes to feature%2Fpipeline-test and that decodes to feature/pipeline-test.

Looks like the plugin here is encoding the URL correctly. I don't know why you have such URL in Jenkins. Sounds like a problem with Jenkins, not with this plugin.

tomasbjerre avatar Dec 11 '18 13:12 tomasbjerre