pull-request-notifier-for-bitbucket icon indicating copy to clipboard operation
pull-request-notifier-for-bitbucket copied to clipboard

Published 20 hours ago • verified publisher icon tomasbjerre

EVERYTHING_JSON variable for use in POST/PUT body

Open johntconklin opened this issue 8 years ago • 1 comments

An enhancement I'd find useful is a ${EVERYTHING_JSON} variable that expands to the JSON representation of all variables.

This new variable is would be like the existing ${EVERYTHING_URL}, except instead of being used as URL query parameters, it would be used as the body of a POST/PUT request. And since it's in the body, there shouldn't be issues wrt size, so unlike ${EVERYTHING_URL}, ${EVERYTHING_JSON} could include the value of ${PULL_REQUEST_DESCRIPTION}.

johntconklin avatar May 17 '17 16:05 johntconklin

I discovered a benefit of JSON encoded that I hadn't realized when I first posted this suggestion -- lists of items can be expressed as real lists instead of comma delimited strings.

It turns out that some of our user's display names are of the form "Lastname, Firstname", which means that I can't reliably extract them from variables like ${PULL_REQUEST_REVIEWERS}. I can call back to Bitbucket's /rest/api/1.0/users/{userSlug} endpoint for each user in ${PULL_REQUEST_REVIEWERS_SLUG}, but ideally I wouldn't need to do that.

johntconklin avatar May 24 '17 01:05 johntconklin