pull-request-notifier-for-bitbucket icon indicating copy to clipboard operation
pull-request-notifier-for-bitbucket copied to clipboard

Published 20 hours ago • verified publisher icon tomasbjerre

Additional comment info on comment added events

Open igogrek opened this issue 8 years ago • 4 comments

First of all thank you for a great plugin! Super useful.

I have a feature request for additional comment info on comment events

PullRequestCommentAddedEvent has DiffCommentAnchor. Is it possible to add some of this info to the available variables?

Use case: I sent comment notifications to users on comment events and it would be nice to have either URL to exact place where comment added, or even better - part of the commented code (but it seems this is not in DiffCommentAnchor and will require additional calls )

igogrek avatar Feb 21 '17 15:02 igogrek

Bitbucket Server deprecated the comments API and will introduce something new in version 5.

https://developer.atlassian.com/bitbucket/server/docs/latest/reference/api-changelog.html#Bitbucket_Server_4.13

I dont know yet how exactly that will work. But 5.0 will be released very soon and I think I would like to wait and add this until 5.0 is released. To avoid adding something that will immediately be deprecated.

tomasbjerre avatar Feb 23 '17 18:02 tomasbjerre

CommentThread interface sound very promising and probably will help to add more useful functionality except just comment file link. Hopefully 5.0 will be there soon

igogrek avatar Feb 23 '17 18:02 igogrek

Since 5.0 is released and supported by plugin now, any news on comment API?

igogrek avatar Jun 14 '17 15:06 igogrek

I did not change any of the comments events when making it compatible with 5.0.

So should be no problem implementing this after som investigation of what is needed to construct such URL:s.

But i'm pretty busy now, PR:s are welcome =)

tomasbjerre avatar Jun 14 '17 15:06 tomasbjerre