vim-npr icon indicating copy to clipboard operation
vim-npr copied to clipboard

Globally configure dirs through vim_npr_default_dirs in .vimrc

Open nkabbara opened this issue 5 years ago • 3 comments

Hello,

Thanks for the great plugin.

Is this the correct way to add 'src/screens' to the lookup path? When I do so in package.json it works fine, but most of my projects have 'src/screens' and I'm trying to configure it globally through .vimrc.

let g:vim_npr_default_dirs = ["src", "lib", "test", "public", "node_modules", "src/screens"]

nkabbara avatar Mar 14 '20 00:03 nkabbara

Hey Nash,

This list of default dirs is only used if the resolve key is not found in the package.json.

It could be possible to add a separate list of paths to be appended to the resolve key list, which would allow you to apply this path globally.

I'm currently on holiday, but I'd be happy to merge a PR if you would like to work on it.

Cheers

tomarrell avatar Mar 19 '20 00:03 tomarrell

Yup, I made sure the key isn’t there, but it still wasn’t taking. That’s the behavior I want actually.

On Wed, Mar 18, 2020 at 6:20 PM Tom Arrell [email protected] wrote:

Hey Nash,

This list of default dirs is only used if the resolve key is not found in the package.json.

It could be possible to add a separate list of paths to be appended to the resolve key list, which would allow you to apply this path globally.

I'm currently on holiday, but I'd be happy to merge a PR if you would like to work on it.

Cheers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tomarrell/vim-npr/issues/5#issuecomment-600921358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAHY6MTVLZ2QUQYLIFWD2DRIFQMFANCNFSM4LHWEVPQ .

nkabbara avatar Mar 19 '20 20:03 nkabbara

Hmm that seems odd. I’ll have to have a look. Would you be able to provide an minimum reproducible example that I can test on?

On Fri 20. Mar 2020 at 9:22 AM, Nash Kabbara [email protected] wrote:

Yup, I made sure the key isn’t there, but it still wasn’t taking. That’s the behavior I want actually.

On Wed, Mar 18, 2020 at 6:20 PM Tom Arrell [email protected] wrote:

Hey Nash,

This list of default dirs is only used if the resolve key is not found in the package.json.

It could be possible to add a separate list of paths to be appended to the resolve key list, which would allow you to apply this path globally.

I'm currently on holiday, but I'd be happy to merge a PR if you would like to work on it.

Cheers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tomarrell/vim-npr/issues/5#issuecomment-600921358, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAAHY6MTVLZ2QUQYLIFWD2DRIFQMFANCNFSM4LHWEVPQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tomarrell/vim-npr/issues/5#issuecomment-601398320, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4SLA4NZCF3US7XG2O4WNDRIJ5JHANCNFSM4LHWEVPQ .

tomarrell avatar Mar 19 '20 20:03 tomarrell