breaktimer-app icon indicating copy to clipboard operation
breaktimer-app copied to clipboard

Assets to make the tray icon dynamic

Open pieterdd opened this issue 4 years ago • 5 comments

As mentioned in https://github.com/tom-james-watson/breaktimer-app/discussions/107, I've generated dynamic tray icons that indicate how close you are to your next break. I've made 10 of them indicating 0%, 10%, 20%, ... 80%, 90% and 100%. Given the size of the tray icon this should be granular enough for users.

Was going to contribute the code for this as well but ran into some roadblocks. I was expecting getSettings().breakLength to be an object indicating a period of time like a Moment.js Duration object. According to the type definition it's actually a Date that's set to 1899-12-31 00:20:00, and according to VSCode's debugger it's a string. Which means that before I can get started on this feature, I'd have to refactor existing usages of breakLength so that reality is consistent with the type definition. Due to time constraints, I'll just stick to contributing the icons for now.

Included is also a vector recreation of the tray icon in monochrome. I made it so it's easier to generate an additional set of tray icons for Mac in the future.

pieterdd avatar Sep 21 '21 20:09 pieterdd

Hello!

This is really awesome! I'm currently working on a new version of the app which has a huge number of code changes. I'll revisit this once that is finished and released, which should be over the next couple of weeks :pray:.

tom-james-watson avatar Oct 02 '21 13:10 tom-james-watson

@tom-james-watson Any chance this change could be integrated now? Monochrome icons for dark desktop themes would be great!

holocronweaver avatar Oct 25 '22 00:10 holocronweaver

I don't have the motivation/bandwidth to work on this myself at the moment. PRs are welcome, of course!

tom-james-watson avatar Oct 25 '22 08:10 tom-james-watson

@tom-james-watson What work is needed prior to merge?

holocronweaver avatar Oct 25 '22 18:10 holocronweaver

Oops replied to quickly and forgot this was already on a PR.

There needs to be some new code that sets the tray icon dynamically based on the time left to the next break.

Agree that ideally the icons would just be monochrome at this point.

tom-james-watson avatar Oct 25 '22 23:10 tom-james-watson