tracing
tracing copied to clipboard
tokio-rs
subscriber: don't gate `with_ansi()` on the "ansi" feature
The commit 1cb523b87d3d removed this cfg gate on master. However, when the change was backported in 049ad730c1ba the docs were updated but the cfg change was omitted. Some more detail and links are in issue #2996.
This made the docs misleading, since they say "This method itself is still available without the feature flag."
Fixes #2996.
I'm not sure if this escaped notice, but it looks like this bug was introduced by an error during backporting. I'm not trying to make policy decisions for the stable branch, just trying to finish the job that was started by @hawkw in #2570.
Github actions aren't starting. I'm guessing that's because this PR is more than 30 days old. I'll try a no-op push to the branch to see if it gets things moving.
Ah, now it's stopped by "This workflow requires approval from a maintainer." @hawkw can you help?
Also, auto-merge was disabled because I pushed to the branch. (No changes were made.)
Ping? @hawkw you approved this PR but CI won't run until a maintainer intervenes.
Clippy lint warnings appear to be unrelated; CI runs latest stable and at least some of the lints are things I recognize as being new in 1.80.
CI is blocked on "This workflow requires approval from a maintainer". Could someone help move it along?
As far as I can tell, this is ready to merge. It's a very simple fix and received approval months ago.
Could someone please approve the CI workflow for this PR? As seen earlier, if it gets more than 30 days old then CI won't be able to run.
Rebased again on the latest v0.1.x branch. There were no conflicts. This PR still needs manual approval for CI to run.