tracing icon indicating copy to clipboard operation
tracing copied to clipboard

potential binary bloat caused by `matchers`

Open mokurin000 opened this issue 1 year ago • 4 comments

Feature Request

Crates

tracing-subscriber

Motivation

tracing-subscriber depends on matchers, which depends on old regex-autometa, results a huge binary bloating when users want to use latest regex.

While there are two PR to bump dependency, may the owner havn't had time to review.

Proposal

Fork matchers and publish a matchers2 if hawhw don't want to transfer that crate.

Alternatives

Still wait until @hawkw merged the bump-dep PR

mokurin000 avatar Apr 02 '24 05:04 mokurin000

@hawkw any chance you'll have time soon to look into updating matchers? There are PRs open already.

smmalis37 avatar May 12 '24 16:05 smmalis37

@hawkw any chance you'll have time soon to look into updating matchers? There are PRs open already.

check https://github.com/tokio-rs/tracing/pull/2945 I don't expect she will merge these PR

mokurin000 avatar May 13 '24 00:05 mokurin000

Hi! Just want to chime in that this is something we noticed was duplicated in our tree. It looks like this is blocked waiting for

  • https://github.com/hawkw/matchers/pull/5

zanieb avatar Jul 01 '24 21:07 zanieb

matchers 0.2.0 is published now, which fixes the problem.

asomers avatar Jul 21 '24 13:07 asomers