WebGoat.NET icon indicating copy to clipboard operation
WebGoat.NET copied to clipboard

Published 20 hours ago • verified publisher icon tobyash86

Remove raw SQL usage from the codebase

Open tobyash86 opened this issue 5 years ago • 5 comments

There are some raw SQL queries in the code. We should consider using EF Core instead. For some reason EF does not work properly in the checkout, we need to find out why and fix it.

tobyash86 avatar Jun 15 '20 19:06 tobyash86

The issue causes an exception when two exactly the same products are added to the cart.

The bug exists due to the fact that we call SQL manually to populate tables during checkout. We generate SQL with the same keys twice for the same products.

tobyash86 avatar Jun 15 '20 19:06 tobyash86

It seems like fixing the cart did not help with removing raw SQL. The main issue still exists.

tobyash86 avatar Jun 18 '20 12:06 tobyash86

Fixed. Requires verification on dev branch.

tobyash86 avatar Nov 17 '20 08:11 tobyash86

Reverted changes - there were issues with checking out with over 3 items in the cart.

ma-rybak avatar Nov 18 '20 14:11 ma-rybak

Branch issue-20-Remove_raw_SQL_usage_from_the_codebase created!

create-issue-branch[bot] avatar Nov 18 '20 21:11 create-issue-branch[bot]