Tobiloba Adedeji

Results 224 comments of Tobiloba Adedeji

> @tobySolutions I would like to work on this issue if no one is currently working on it. > @ramzibouzaiene is currently working on it. 👀👀

> @tobySolutions maybe the problem my node version ? what node version should i use for the project ? I'm on a 16.6.6, what's yours?

Thank you @ramzibouzaiene. Have you found it yet @RutamBhagat? Also, were you able to get the project to run locally?

> @tobySolutions I am able to run the project locally and I found the theme.config.tsx file but I am unable to understand where the jsx of Dark mode toggle button...

Hmm, 🤔🤔🤔. I've actually never tried this.

> > If the points I make are good ones, may I make a pull request? > > Currently, the eslint rules used by the repo are enforcing `value ===...

> > Hmm, interesting. Thanks Sukka! > > I am considering re-visit this. If `== null` is fast enough, we should disable that eslint rule (since nobody uses `docuemnt.all` now)....

> > Hmm, interesting. Thanks Sukka! > > I am considering re-visit this. If `== null` is fast enough, we should disable that eslint rule (since nobody uses `docuemnt.all` now)....

> > > We will need to do some benchmarks on this, to see if changing to == null is really worth it. > > > > Would you like...