rightmove_webscraper.py icon indicating copy to clipboard operation
rightmove_webscraper.py copied to clipboard

Published 20 hours ago • verified publisher icon toby-p

Added image_url of the first listing image to the output table

Open williamy2k opened this issue 3 years ago • 2 comments

Hello, as discussed I added retrieving the primary property image. This is my first Github pull request so apologies if I got something wrong, happy to amend.

williamy2k avatar Sep 05 '22 20:09 williamy2k

Apologies for the delay!

This seems like a good idea but I think first I'd like to understand if it slows down the requests by a significant time? If so it would be better to make it optional (as with the get_floorplans parameter).

Also, I think I'd lean towards scraping all the image urls as a list if possible as it seems like that would have a lot more use cases. Not sure how much more effort that would be...

toby-p avatar Apr 04 '23 01:04 toby-p

For what it's worth, I pulled this commit into my own branch and didn't notice any measurable performance impact (it's just another xpath on the pre-scraped HTML).

des1redState avatar Apr 04 '23 09:04 des1redState