Thomas Singer

Results 84 comments of Thomas Singer
trafficstars

The latest SmartGit 25.1 preview build is based on b8dd804. The problem did not occur with the SWT build used in SmartGit 24.1. I have seen it for top level...

I just have one monitor here. So you suggest this bug might be fixed by updating to latest master?

So cherry-picking d12ad69a would be sufficient to get the fix? After the regressions I had the last 3 times I've upgraded SWT, I'm somewhat reluctant to update to the most...

I'm cherry-picking d12ad69 and will report after a couple of daily usage whether the missing app icons still appear.

Unfortunately, having cherry-picked d12ad69 did not fix the broken shell image problem for me.

Not getting any more feedback from me regarding this topic does not mean the problem is fixed. We just switched to an older SWT build for the upcoming SmartGit release....

@ptziegler Your example only is a shortcut for those (rare?) case where you draw the image at (0, 0). I agree with the meaning of x/y for a size, but...

> I rather meant that with cleaner class design, one might have some `Dimension` (or, in our case unfortunatly, `Point`) class with > some `asBounds()` or the like, i.e., something...

> Just out of curiosity, what's the motivation behind touching the getBounds() method? I just noticed that `getBounds()` had always zero coordinates while a `getSize()` was missing. For me, the...

> So is it only about boilerplate code required due to abscence of `getSize()`, right? Then the issue remains that we have no proper return type to be used for...