Tommaso Piazza

Results 224 comments of Tommaso Piazza
trafficstars

I don't work with submodules enough to feel qualified to review the change. I think @mdiep should be reviewing here. @CosynPa Ad high level description of the problem and the...

Try this patch: ```diff diff --git a/Source/CarthageKit/Project.swift b/Source/CarthageKit/Project.swift index ae282c01..54e8a51c 100644 --- a/Source/CarthageKit/Project.swift +++ b/Source/CarthageKit/Project.swift @@ -8,6 +8,18 @@ import XCDBLD import ReactiveTask import struct SPMUtility.Version + +let dsp =...

@sjmueller It won't. The root of the problem hasn't been found. However, maybe you can take a stab at it (since it's important for your work) and make a PR!...

> Thanks for letting me know how open source works. If the core contributors can’t find the problem, I certainly wouldn’t be able to either. Great! So you'll cover me...

This should work is there is a dSYM provided. I'm not sure if it works with no Obj-C Header but embedded symbols. I'll mark this as enhancement if anyone wants...

This issue https://github.com/Carthage/Carthage/issues/2294 discusses improvements to the Cartfile and a possible new format where what you want should be possible

@kuchmiyalex feel free to work on the issue.

> Carthage therefore downloads /2.3/framework.zip and unarchives it. Not quite. What it downloads is the minimum compatible version. Which of the two depends on the dependency resolution happening when the...

I don't thing `"tag"` and `"link"` are the appropriate names for those keys. Instead of "link", maybe `location` ? Instead of "tag" maybe `constraint` ? I very much like the...

> less readable (at least for me) and we can't write comments in JSON. In #2294 I suggested yaml that can help in both.