BugfixedHL-Rebased icon indicating copy to clipboard operation
BugfixedHL-Rebased copied to clipboard

Published 20 hours ago • verified publisher icon tmp64

Client: Allow to specify name for kill sound and regulate volume

Open SmileyAG opened this issue 3 years ago • 1 comments

Closes #132

SmileyAG avatar Mar 02 '22 22:03 SmileyAG

Volume control will stop working as soon as "Apply" is pressed in the advanced options dialog because CCvarCheckButton only allows boolean values https://github.com/tmp64/BugfixedHL-Rebased/blob/07aecfff8bacaccc1aad1516d342041e4a4aca87/src/game/client/gameui/options/cvar_check_button.cpp#L17-L40

I see two ways to resolve that a. Replace checkboxes with sliders. But there's barely any space for anything as it is. b. Modify CCvarCheckButton to only update the value if it was changed.

tmp64 avatar Mar 08 '22 03:03 tmp64

Rebased on top of master

tmp64 avatar Dec 03 '23 05:12 tmp64

Thanks!

tmp64 avatar Dec 03 '23 05:12 tmp64

I see two ways to resolve that a. Replace checkboxes with sliders. But there's barely any space for anything as it is. b. Modify CCvarCheckButton to only update the value if it was changed.

I changed CCvarCheckButton to only apply if the user clicked the checkbox (f4deeab9168dff03444683d6ef59cd0be15f4ab6).

tmp64 avatar Dec 03 '23 05:12 tmp64