langchaingo icon indicating copy to clipboard operation
langchaingo copied to clipboard

fix(llms/openai): correct JSON tag omitempty

Open spatecon opened this issue 9 months ago • 1 comments

Fixes #1162

This won't expose - as a json field where it was intended. I've also checked the rest of code base for the same issue: nothing else found 👍🏻

Doesn't really introduces anything new.

PR Checklist

  • [x] Read the Contributing documentation.
  • [x] Read the Code of conduct documentation.
  • [x] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • [x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • [x] Describes the source of new concepts.
  • [x] References existing implementations as appropriate.
  • [x] Contains test coverage for new functions.
  • [x] Passes all golangci-lint checks.

spatecon avatar Feb 19 '25 22:02 spatecon

Seems like linter is failing. I am going to rebase when main becomes healthy.

spatecon avatar Feb 19 '25 22:02 spatecon