langchaingo icon indicating copy to clipboard operation
langchaingo copied to clipboard

llms/openai: fix for openallm function calls - must have a Name

Open kraney opened this issue 11 months ago • 2 comments

PR Checklist

  • [ ] Read the Contributing documentation.
  • [ ] Read the Code of conduct documentation.
  • [ ] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • [ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • [ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
  • [ ] Describes the source of new concepts.
  • [ ] References existing implementations as appropriate.
  • [ ] Contains test coverage for new functions.
  • [ ] Passes all golangci-lint checks.

kraney avatar Dec 12 '24 05:12 kraney

@kraney Can you fix the lint and add a test that checks for this?

FluffyKebab avatar Jan 05 '25 03:01 FluffyKebab

@kraney can you rebase this?

tmc avatar Feb 13 '25 04:02 tmc