Teodor Maxim

Results 27 comments of Teodor Maxim

Sorry for taking so long to merge #23. Released this particular update under [v0.9.0-pre.1](https://github.com/tmaxmax/go-sse/releases/tag/v0.9.0-pre.1).

Hi @gostega, thank you for giving `go-sse` a try! Could you maybe open a new discussion and share the code, along with a broader explanation of what you're trying to...

Thank you for the PR! > if you're already serialising access to the replay providers This is done inside the provider, replay providers are not required to be thread safe....

> One could argue that it's still a bug as the programmer failed to properly validate the input 🤷 but it's definitely not a static one. You're right here –...

Where is that test failing? I should be able to help with that.

The test verifies the behavior of `Joe` on client errors. At the beginning it publishes two messages so that there is something to replay when a client is subscribed – ...

Let's leave the code as it is for now. I'll do some research to see what other libraries – in and outside the Go ecosystem – implement. As a curiosity,...

Hm, this is indeed important. Perhaps there should be a specific kind of error `ReplayProvider`s should return which indicates that for the given LastEventID nothing could be replayed. Then there...

I'll remove that feature for the moment. If you have the resources, could you add the suggested test in the code review?

We don't really have a way to track deallocs, given that those are the GCs responsibility and it decides when to do them. Besides the replay provider is usually part...