Thomas Lively

Results 857 comments of Thomas Lively

🎉 🎉 🎉

I would be ok with landing this as-is and applying fixups in follow-on PRs after the fuzzer passes :+1: Edit: It might be useful to first update printing to elide...

Oh hmm, I guess this is a downside of mutating recent tests. The fuzzer could not have created that program itself.

This seems to be an error message from tinygo rather than Binaryen. Although it looks like it's prompting you to build binaryen yourself. Have you tried that?

The general problem here is that wasm2js does not support 64-bit memories right now. I'll change the issue title to reflect that, but I'm not sure how wasm2js even would...

Is this a GitHub feature or some external service?

The problem here is that Binaryen does not even support parsing loops (or blocks) with input parameters. The fix would not be in the relooper code, but in the parsing...

No, nothing concretely planned at the moment, unfortunately. Can you share more about your use case?

It would be nice to support _parsing_ block input types by introducing new locals to hold the values as they enter the block. It would also be nice to optimize...

The loop example passes validation after Binaryen's binary parser gets through with it, but I'm pretty sure the parser completely changes the program's semantics. I double checked and the binary...