django-subdomains icon indicating copy to clipboard operation
django-subdomains copied to clipboard

Added compatibility with Django 1.10

Open ma0c opened this issue 8 years ago • 4 comments
trafficstars

Django 1.10 change the way to declare middleware but add a compatibility MiddlewareMixin to help the migrations. Also patterns was removed from django.conf.urls and django.conf.urls.defaults, and allows urlpatterns variable to be simple list. So, in case patterns functions is not found, we replace with a custom function that transforms the input args in a list.

ma0c avatar Mar 16 '17 21:03 ma0c

Can someone chime in on the status of this pull request, or recommend a fork of this project that is actively maintained?

shacker avatar Jun 20 '17 17:06 shacker

Hmm. I uninstalled the pip version and instead installed via git+https://github.com/contraslash/django-subdomains but am getting the same error against Django 1.11.

shacker avatar Jun 20 '17 18:06 shacker

Ah, this fork/fix does work with Django 1.11: https://github.com/abe312/django-subdomains

shacker avatar Jun 20 '17 18:06 shacker

yup! I uploaded the same to pypi under subdomains so you could simply: pip install subdomains

abe312 avatar Jun 24 '17 12:06 abe312