feat: implement club announcement restrictions

[JasonGrace2282]

trafficstars

Nowhere near finished

This makes it so that announcements that are created by a restricted club are only shown to people who are allowed to access the restricted club.

Progress on performance issues

Indexes don't seem to help much, most likely caching is the only way.

[coveralls]

coverage: 79.155% (+0.06%) from 79.098% when pulling 56c379c8689267465fb6c59e7b754877686dff41 on JasonGrace2282:club-ann-restrict into f80a619a458cc72522fa42b6f596c5786cd30d7c on tjcsl:dev.

[alanzhu0]

So it seems fine performance-wise. But I think you need to be more careful and check everywhere this query is used. I'm not sure that this one instance will cover everything. Basically, shore it up some more.

• Can you also make it so people not on the allowed list/groups can't subscribe to the activity?
• And when those groups are updated, maybe you can consider also automatically removing the people removed from those groups from the subscribed list
• Also, we discussed this, but maybe instead of checking if the activity is restricted, just have a checkmark to specifically restrict club announcements. So restricted activities could still make their announcements public. I don't think we need the case where a public activity has restricted announcements. This may also have performance benefits.
• And for that, can you add some text on the post announcements page and the activity edit page that states that the announcements are restricted?

[alanzhu0]

LGTM, just to check though did you run lint/build/test on local?

[JasonGrace2282]

LGTM, just to check though did you run lint/build/test on local?

CI is working again, and it passes all 3 (with the exception of the known problem about gathering the csl status).