ion
ion copied to clipboard
tjcsl
feat(bus): option to mark bus as delayed
Closes #1414
Proposed changes
- Added the option to mark a bus as delayed in the afternoon bus page
Brief description of rationale
-So people can see if their bus is delayed.
Coverage: 81.279%. Remained the same when pulling 81b26ac165d441d7be658c2f626efa4f991ba7f3 on IshanA2007:master into 7cc4dcbec49fe9e0a016e8f801805544cd026312 on tjcsl:dev.
I have a few comments - I'll add them later this evening after I get a chance to test a bit more.
Make sure to remove all the artifacts from squashing your commits. I noticed a lot of what looks like merge conflict errors, i.e. >>>>>>> 45142c57 (feat(bus): option to mark bus as delayed) on line 218.
Good work fixing the issues from before. Here are a few more comments. Note that none of these are actually bugs in your code - these are just UX subtleties that I think should be present. I've commented the ones I've noticed, but when you go about revising, think about what you would consider the smoothest UX and adjust the functionality accordingly.
- After a Fairfax bus has been marked as delayed, there should be an option in the dropdown to mark it as on time again.
- After a non-Fairfax bus has been marked as delayed, there should be an option in the dropdown to mark it as arrived, rather than having to mark it as on time and then arrived.
Alternatively, instead of dealing with these dropdown UX issues, you could redesign the UI to be smoother and directly improve the UX. For example, as I mentioned in the issue description, take a look at the morning bus page dropdown:
You could implement this for the afternoon bus page - much of it would be the same as the morning. The only difference would be for Fairfax buses, where the "Arrived" button should be grayed out so that it can be assigned a space on the map. Also look at the morning bus list:
It would also be useful to have this on the side of the bus page for bus admins to quickly check the status of all the buses (it can be annoying to look at the map for administrative functions). Again, this will likely amount to just a copy-paste from the morning bus page.
This UI improvement is optional. If you choose to do it, it would be the facelift the bus app has needed for a while, but if not, adding the delayed feature would be an improvement satisfying the issue.
Good luck!