Tim Jaeryang Baek

Results 520 comments of Tim Jaeryang Baek
trafficstars

LGTM! Appreciate all the effort, let's monitor the situation with python-socketio, feel free to open subsequent PRs once they start supporting redis sentinel natively.

We might want to make this a toggleable option, some users do not necessarily want to see the reasoning content

Generally more testing wanted but I'll merge this PR for now, thanks! 🙌

Addressed with ca0b7217d23812ca74359f4214a066b1737c8db6 in dev! ![Image](https://github.com/user-attachments/assets/a7cc1960-4d54-4878-8aed-cda3df007d11)

This is a lot trickier than just adding `if-else` conditions, the user may include multiple files alongside web search and have `Bypass Embedding and Retrieval` enabled for one and not...

Agreed this must be supported, PR welcome here but eventually I'll be taking a look.

Added with 2c7ccc69fe614b65bb584b53b89c3eee2eac894b

Addressed with 33c206c15c952d626dbe11a702701665dce19ec4