git-extras icon indicating copy to clipboard operation
git-extras copied to clipboard

Include git-find

Open Natureshadow opened this issue 9 years ago • 8 comments
trafficstars

Dear git-extras maintainers,

I'd like to propose to include the git-find tool form mirabilos/git-find in git-extras. It is a really handy tool allowing GNU find-like searching through paths known to Git, but is too small to be packaged alone.

Natureshadow avatar Oct 10 '16 22:10 Natureshadow

Well, looks like the MirOS license allows it.

anatolyborodin avatar Oct 12 '16 13:10 anatolyborodin

Sure. It's more-or-less MIT/Expat.

Natureshadow avatar Oct 13 '16 10:10 Natureshadow

Should I do a pull request with it? Should I copy it in then, or do a real subtree-merge?

Upstream would acknowledge merging into git-extras.

Natureshadow avatar Oct 13 '16 10:10 Natureshadow

In my opinion, a simple copy is enough(Don't forget to write docs!).

@hemanth @qw3rtman @nicolaiskogheim Any suggestions?

spacewander avatar Oct 13 '16 14:10 spacewander

In my opinion, a simple copy is enough(Don't forget to write docs!).

Upstream stated that he wouldn't mind moving upstream development to git-extras and drop the seperate repository. I like keeping the history, in that case.

Natureshadow avatar Oct 13 '16 14:10 Natureshadow

I jsut notice that git-extras seems to mandate use of bash… If so, why's that, and can a ksh script be included?

Natureshadow avatar Oct 13 '16 14:10 Natureshadow

Bash is the most common shell, shipped by Linux and Mac OS as default choice. Stick to bash, therefore users can get the features out of box. A ksh need to be rewritten with bash, if we want it to be a part of git-extras.

spacewander avatar Oct 15 '16 05:10 spacewander

Bash is the most common shell

Now this is simply not true.

ksh (mksh) is the default shell on many BSDs and on some 80 million or so mobile devices (Android).

Sticking to bash is nothing but an arbitrary choice made for git-extras.

Oh, and most of the scripts in here don't even need bash. A POSIX compatible sh is still the most common shell.

I will come up with something.

Natureshadow avatar Oct 15 '16 07:10 Natureshadow