Bruno Deferrari

Results 145 comments of Bruno Deferrari

Possible alternative https://github.com/swellaby/rusty-hook

Ok, edited to use https://crates.io/crates/cargo-husky This dependency's build script will copy our custom hooks to where they should be, no need to manually link anything

So... I don't really like this empty-subcrate-with-that-dependency approach much tbh, maybe a `Makefile` (or with https://sagiegurari.github.io/cargo-make/) command to set the hooks would be better.

@bkontur what I mean is for setting up the git pre-commit hook, because it cannot be part of the repository (one could put something dangerous in there). On this PR...

@binier about to merge this one, looks good to you?

Hmmm.. now that I look at this again, it should probably use `spawn_blocking` instead of `block_in_place`, the calling function is async.

Although maybe I tried spawn_blocking before ant it didn't work because values need to be send+sync, not sure now🧐

`tools/fuzz` ? (along with anything else that may come later that is meant for node developers and not end-users)

Btw, here you can see how the messages are sent from the async client: https://github.com/tezedge/tezedge/blob/9ea5f403c4e60945f1c468e4909f688c9f2bbb6c/tezos/protocol-ipc-client/src/lib.rs#L627-L680 The macro handles a situation where the message received is not the expected one, but...

Ah, one more detail, you will see that now there are two kind of messages, `*ForPrevalidation` and `*ForMempool`. The `*ForPrevalidation` messages are stateless, while the `*ForMempool` messages accumulate state. Depending...