tinygo icon indicating copy to clipboard operation
tinygo copied to clipboard

Published 20 hours ago • verified publisher icon tinygo-org

Fix for #4678: top-level 'make lint' wasn't working

Open cibomahto opened this issue 10 months ago • 2 comments
trafficstars

As noted in #4678, the revive command seems to have had a syntax error in the file input glob. It appears to have been broken in a way that did not result in a return code being set. This change uses 'find' to build the input to the linter.

Note that it is expected to fail the CI script, because it is uncovering some existing lint issues that were not being caught.

cibomahto avatar Jan 02 '25 17:01 cibomahto

This PR seems like a good thing, but then suddenly will require a followup to fix all of the issues it raises, if I am not mistaken?

deadprogram avatar Feb 14 '25 12:02 deadprogram

You are correct! If the issues that this surfaces aren't important, then an alternative is to just delete this test.

cibomahto avatar Feb 14 '25 12:02 cibomahto

Closing this PR since the commits were merged in #4997

Thank you @cibomahto for the fixes and to @b0ch3nski for review.

deadprogram avatar Sep 14 '25 12:09 deadprogram