tinygo icon indicating copy to clipboard operation
tinygo copied to clipboard

Missing C.CBytes

Open hectorchu opened this issue 1 year ago • 4 comments
trafficstars

C.CString is present but C.CBytes is not.

Workaround is unsafe.Pointer(C.CString(string(data))) but that's ugly.

hectorchu avatar Jun 05 '24 06:06 hectorchu

Looks like someone almost got it added here https://github.com/tinygo-org/tinygo/pull/3318

Probably we just need to rebase that PR?

deadprogram avatar Jul 23 '24 07:07 deadprogram

I rebased PR #3318 since the original author was not really responsive anymore in their PR. Here is the rebased version, all tests pass https://github.com/tinygo-org/tinygo/pull/4470.

@deadprogram would you mind giving this a review?

leongross avatar Sep 17 '24 11:09 leongross

@deadprogram I think this can be closed then?

leongross avatar Sep 19 '24 10:09 leongross

@leongross it has been labeled to be closed on the next release.

deadprogram avatar Sep 19 '24 11:09 deadprogram

Now closing. Thanks everyone!

deadprogram avatar Oct 30 '24 20:10 deadprogram