tinygo icon indicating copy to clipboard operation
tinygo copied to clipboard

Published 20 hours ago • verified publisher icon tinygo-org

os/user.Lookup

Open leongross opened this issue 1 year ago • 17 comments
trafficstars

Add support for User lookup via os/user.Lookup()

leongross avatar Apr 04 '24 15:04 leongross

@deadprogram any thoughts on this?

leongross avatar Apr 05 '24 16:04 leongross

@deadprogram do you have any recommendations on what to improve or does this look good to you?

leongross avatar Apr 16 '24 15:04 leongross

@aykevl maybe you can have a short look at this?

leongross avatar Apr 23 '24 16:04 leongross

ping for review

10000TB avatar Apr 30 '24 05:04 10000TB

Just waiting for #4027 to land before any more changes to this part of the code.

deadprogram avatar May 01 '24 07:05 deadprogram

for some reason smoke test test-llvm15-go118 fails again

leongross avatar May 10 '24 11:05 leongross

for some reason smoke test test-llvm15-go118 fails again

That's https://github.com/tinygo-org/tinygo/issues/4206

aykevl avatar May 13 '24 14:05 aykevl

Not quite sure why the windows build fails here: ld.lld: error: undefined symbol: notARealFunction

leongross avatar May 21 '24 14:05 leongross

commit 7b7601d77c681a3c2ce53ce3f89dbdfc35eec492 added stubs, but we should still get this functionality in @deadprogram

leongross avatar Jun 04 '24 13:06 leongross

Since I did not touch the rp2040 specific code, it looks like yet another CI error

/go/bin/tinygo build -size short -o test.hex -target=nano-rp2040 examples/rtcinterrupt unexpected fault address 0x27cc fatal error: fault [signal SIGSEGV: segmentation violation code=0xfffffffffffffffa addr=0x27cc pc=0x6e9d62]

leongross avatar Jun 04 '24 13:06 leongross

@deadprogram @aykevl the CI race again, ready to merge?

leongross avatar Jun 06 '24 15:06 leongross

@aykevl @deadprogram @dgryski @10000TB

leongross avatar Jun 11 '24 14:06 leongross

anyone with approval power care to approve ?

10000TB avatar Jun 11 '24 17:06 10000TB

@leongross can you please rebase this PR against the latest dev? Thanks!

deadprogram avatar Jun 15 '24 09:06 deadprogram

@deadprogram rebase done

leongross avatar Jun 16 '24 11:06 leongross

@aykevl

leongross avatar Jun 18 '24 16:06 leongross

Looking for an approval ! TY

10000TB avatar Jun 25 '24 16:06 10000TB

@deadprogram @aykevl

leongross avatar Jul 02 '24 10:07 leongross

Oh sorry I totally forgot about this PR! @leongross what do you think about #4324? It defers to the Go stdlib for the os/user package by setting the osusergo build tag, which means we have less to maintain in TinyGo.

aykevl avatar Jul 02 '24 15:07 aykevl

If the usergo tag works as I would suspect this should resolve this PR and any further implementations, looks really promising!

leongross avatar Jul 16 '24 11:07 leongross

@leongross @aykevl so that means #4324 would replace this PR, correct?

deadprogram avatar Jul 18 '24 15:07 deadprogram

@leongross @aykevl so that means https://github.com/tinygo-org/tinygo/pull/4324 would replace this PR, correct?

Just wondering... :smile_cat:

deadprogram avatar Jul 23 '24 16:07 deadprogram

@leongross @aykevl so that means #4324 would replace this PR, correct?

Just wondering... 😸

I hope so :) This would be a good generic solution, I cannot think of any use case atm where the implementation covered in this PR would make a difference.

leongross avatar Jul 23 '24 16:07 leongross

#4324 is successfully merged so this can be closed.

leongross avatar Aug 22 '24 11:08 leongross