drivers icon indicating copy to clipboard operation
drivers copied to clipboard

rtl8720dn: add handling when connect fails

Open sago35 opened this issue 2 years ago • 2 comments
trafficstars

This PR adds handling when rtl8720dn fails to connect to a specific TCP destination.

-1 represents many rpc failures, but details are unknown. In fact, rtl8720dn returns -1 when a connection fails.

sago35 avatar Dec 27 '22 00:12 sago35

Note in drivers:dev branch, this is fixed as:

result := r.rpc_lwip_connect(int32(sock), name, uint32(len(name)))
if result == -1 {
        return fmt.Errorf("Connect to %s failed", ip)
}

scottfeldman avatar Jan 11 '24 00:01 scottfeldman

@sago35 is this PR still relevant?

deadprogram avatar May 02 '24 17:05 deadprogram

No, it's already been updated to the following code, so the issue is resolved. I'll close this PR.

https://github.com/tinygo-org/drivers/blob/v0.27.0/rtl8720dn/rtl8720dn.go#L501-L505

sago35 avatar May 03 '24 01:05 sago35