drivers icon indicating copy to clipboard operation
drivers copied to clipboard

Published 20 hours ago • verified publisher icon tinygo-org

drv883x: add drv8838 device

Open elliots opened this issue 5 years ago • 3 comments
trafficstars

Some questions:

  • I called it PhaseEnableDevice as that's what's in the pdf, is there a better name?

  • I have only added the 8838 and not the 8837 as I don't have one of those. But it seems simple enough, is it ok to add without actually testing it?

image

https://www.ti.com/lit/ds/symlink/drv8838.pdf

elliots avatar Nov 01 '20 01:11 elliots

Hi @elliots thank you for the contribution. Since you do not have a DRV8837 to test with, perhaps this PR should only cover the DRV8838 and renamed drv8838 instead of drv883x until such time that the functionality for that device can be verified.

What do you think?

deadprogram avatar Nov 07 '20 19:11 deadprogram

Done.

elliots avatar Nov 16 '20 10:11 elliots

Sorry it has been so long to review this.

I notice that this PR needs a smoke test added. Would you like to do it, or would you prefer that I do so.

Thank you.

deadprogram avatar Mar 26 '21 16:03 deadprogram