drivers icon indicating copy to clipboard operation
drivers copied to clipboard

WIP: Wifinina refactor

Open bgould opened this issue 5 years ago • 4 comments
trafficstars

This PR includes a refactoring of the wifinina driver to make the code more readable. It attempts to encapsulate the details of the low-level protocol in the wifinina.Buffer struct. Additionally, a new "Transport" interface is introduced to decouple the driver from the TinyGo machine package; this for instance makes it possible to the driver with a serial converter such as FTDI 232H from standard Go. Support for reading/formatting BSSIDs and MAC addresses is also improved, and UDP support is added and confirmed to work.

Code still needs cleanup but the bulk of the refactor is completed.

bgould avatar Jun 04 '20 05:06 bgould

Hi @bgould could you please rebase against dev branch? The CI should pass if you do so. Thanks!

deadprogram avatar Jun 04 '20 18:06 deadprogram

Looks like that last commit is failing the tests, @bgould

deadprogram avatar Jun 12 '20 16:06 deadprogram

Looks like that last commit is failing the tests, @bgould

Sometimes goimports likes to write package names like github.com/tinygo-org/tinygo/src/runtime instead of just runtime in my setup. Fixed this, CI seems to be passing now. Going back through and cleaning up commented out code and adding comments where some should be added. After that I think this should be ready to remove WIP and review

bgould avatar Jun 13 '20 05:06 bgould

@bgould looks like you are going to need to resolve some merge conflicts, along with whatever else remains to be done on this PR. Thanks!

deadprogram avatar Jun 21 '20 18:06 deadprogram