web-analytics-starter-kit icon indicating copy to clipboard operation
web-analytics-starter-kit copied to clipboard

chore: Tremor update

Open severinlandolt opened this issue 1 year ago • 3 comments

Description

Hi, Severin from @tremorlabs here. I updated the Tremor library as well as tailwindcss and headlessui to their newest versions. Since the Tremor update to v3 has some breaking changes I had to refactor a few files (i.e. tailwind.config and Datepicker).

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation

How Has This Been Tested?

⚠️ I ran the default tests, and there are 3 tests not passing. I am not sure if this is just a local problem on my machine.

CleanShot 2023-11-01 at 12 51 44@2x

Checklist:

  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have update the CHANGELOG
  • [ ] New and existing unit tests pass locally with my changes

severinlandolt avatar Nov 01 '23 11:11 severinlandolt

@severinlandolt is attempting to deploy a commit to the tinybird Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Nov 01 '23 11:11 vercel[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
analytics-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 3:02pm

vercel[bot] avatar Nov 02 '23 10:11 vercel[bot]

Thank you @severinlandolt for updating it! I've added @rmorehig to take a look when possible :)

xavijam avatar Nov 02 '23 10:11 xavijam

Hey @severinlandolt thanks a lot for your contribution, and sorry for the very late response.

This PR does not apply anymore, since we're using our own charting library now.

I'm closing this. Again, thanks for your effort anyways.

alejandromav avatar Sep 24 '24 15:09 alejandromav