action-php-codesniffer
action-php-codesniffer copied to clipboard
Fix run-on-blame ignoring standards file
This fixes https://github.com/tinovyatkin/action-php-codesniffer/issues/40. I hope, I'm a bit unsure whether the path should first be unresolved to an absolute path, or whether that is not required.
Btw, I didn't get to run this locally so couldn't test if this works. If you have some contributing / local development advice, I'm open!
@tinovyatkin it would be great if you have time to look at this!
Ping @tinovyatkin I'd love your view on this if you have the space for it.
@tinovyatkin Would you be able to merge this pull request please?
Thanks for figuring out the problem @lode!
@lode Could we change phpcs.yml to this to test it?
uses: lode/action-php-codesniffer@patch-2
I tried doing that, but I still have no success on the scope: 'blame' mode.
Do you have any other ideas?
@fma-technologies Since author hasn't merged the code yet, I have fixed and published my own fork of it.
If you are facing this issue, you can use this in your yml file:
uses: thenabeel/action-phpcs@v8
@thenabeel Thank you so much for that fork! It got our PSR-12 + blame setup running perfectly. Shame this main repo seems to be dead, but I really appreciate you solving it @lode
@thenabeel Thank you so much for that fork! It got our PSR-12 + blame setup running perfectly. Shame this main repo seems to be dead, but I really appreciate you solving it @lode
@rssteffey I am glad it was useful for you!
@tinovyatkin please merge this