action-php-codesniffer icon indicating copy to clipboard operation
action-php-codesniffer copied to clipboard

Fix run-on-blame ignoring standards file

Open lode opened this issue 5 years ago • 8 comments

This fixes https://github.com/tinovyatkin/action-php-codesniffer/issues/40. I hope, I'm a bit unsure whether the path should first be unresolved to an absolute path, or whether that is not required.

Btw, I didn't get to run this locally so couldn't test if this works. If you have some contributing / local development advice, I'm open!

lode avatar Jun 29 '20 20:06 lode

@tinovyatkin it would be great if you have time to look at this!

lode avatar Jul 07 '20 10:07 lode

Ping @tinovyatkin I'd love your view on this if you have the space for it.

lode avatar Aug 10 '20 14:08 lode

@tinovyatkin Would you be able to merge this pull request please?

Thanks for figuring out the problem @lode!

fma-technologies avatar Sep 02 '20 10:09 fma-technologies

@lode Could we change phpcs.yml to this to test it?

uses: lode/action-php-codesniffer@patch-2

I tried doing that, but I still have no success on the scope: 'blame' mode.

Do you have any other ideas?

fma-technologies avatar Sep 02 '20 11:09 fma-technologies

@fma-technologies Since author hasn't merged the code yet, I have fixed and published my own fork of it. If you are facing this issue, you can use this in your yml file: uses: thenabeel/action-phpcs@v8

thenabeel avatar Jan 05 '21 14:01 thenabeel

@thenabeel Thank you so much for that fork! It got our PSR-12 + blame setup running perfectly. Shame this main repo seems to be dead, but I really appreciate you solving it @lode

rssteffey avatar Jul 28 '22 18:07 rssteffey

@thenabeel Thank you so much for that fork! It got our PSR-12 + blame setup running perfectly. Shame this main repo seems to be dead, but I really appreciate you solving it @lode

@rssteffey I am glad it was useful for you!

thenabeel avatar Aug 12 '22 17:08 thenabeel

@tinovyatkin please merge this

oojacoboo avatar Mar 13 '24 05:03 oojacoboo