playground icon indicating copy to clipboard operation
playground copied to clipboard

Moving tls cert generation to terraform

Open wokalski opened this issue 3 years ago • 2 comments

I've just moved tls cert generation to terraform in my local "fork". I find it much easier to understand than the generate.sh bash script. Would you accept such contribution?

wokalski avatar May 09 '22 18:05 wokalski

I was thinking of doing the same, so yes I for one would like to see!

odacombe-bc avatar Aug 19 '22 19:08 odacombe-bc

Thank you for bringing this up. For me, the challenge with this would be that we'd need to do something similar for vagrant and the bare docker-compose paths as well (if this is the model you are proposing). That's a lot more code, maintenance, and overhead.

If the goal is to improve understandability, maybe improving the code comments/documentation for the generate.shwould be an acceptable alternative? Very open to other ideas too.

jacobweinstock avatar Aug 19 '22 20:08 jacobweinstock

The code has since moved on and no longer performs cert generation. Dubbing this issue as stale.

chrisdoherty4 avatar Dec 16 '22 14:12 chrisdoherty4