cluster-api-provider-tinkerbell icon indicating copy to clipboard operation
cluster-api-provider-tinkerbell copied to clipboard

CAPT Playground

Open jacobweinstock opened this issue 1 year ago • 3 comments

Description

WIP for creating a playground in which to use, learn, and test CAPT.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • [ ] updated the documentation and/or roadmap (if required)
  • [ ] added unit or e2e tests
  • [ ] provided instructions on how to upgrade

jacobweinstock avatar Jan 16 '24 15:01 jacobweinstock

Looking sharp, but I do feel like we should just script this. A lot of the Go code is boilerplate around command invocations as we talked about.

chrisdoherty4 avatar Jan 25 '24 15:01 chrisdoherty4

Looking sharp, but I do feel like we should just script this. A lot of the Go code is boilerplate around command invocations as we talked about.

I'm open to discussing this. Here's my take. Its quite a bit nicer to work with Go for all the yaml creation than a shell script. A single binary is preferable too. I prefer working with Go around writing command, stdout, stderr to log a file than a script. For me, boilerplate in and of itself isnt a strong enough reason to move to shell. Also, this will be a good amount of code regardless of the language. I prefer to not maintaining a large amount of shell script code. I'm keen to know more from your end. Thanks!

jacobweinstock avatar Jan 25 '24 16:01 jacobweinstock

@jacobweinstock Truthfully I glanced through the code and was keying off our last convo; you're in the thick of it, so if you have good reasons I'm good sticking with Go.

chrisdoherty4 avatar Jan 25 '24 20:01 chrisdoherty4

Going to have this be in the https://github.com/tinkerbell/playground repo instead of here. https://github.com/tinkerbell/playground/pull/191

jacobweinstock avatar Jun 20 '24 03:06 jacobweinstock