cluster-api-provider-tinkerbell icon indicating copy to clipboard operation
cluster-api-provider-tinkerbell copied to clipboard

Mergify config not matching github actions jobs

Open detiber opened this issue 3 years ago • 2 comments

Expected Behaviour

Mergify should merge when conditions are met, including the CI jobs defined in github actions

Current Behaviour

Mergify fails to merge the pr, showing that check-success=validate is false even when all github actions have passed.

Possible Solution

Based on https://docs.mergify.com/conditions/#about-status-checks, it looks like the configuration would be correct, in that the github actions job name is validate, however I believe it probably needs to be modified to take into account that the job is a matrix job.

Some investigation will need to be done to determine if we need to specify check-success for all combinations of the matrix job or if there is a way to configure it to check for a prefix or regex matching the matrix jobs.

detiber avatar Feb 01 '22 20:02 detiber

Hey @detiber I just ran into something similar in tink (iirc) which PR did you have trouble with?

mmlb avatar Feb 01 '22 22:02 mmlb

oh validate is a matrix type, yep we'll have to spell out each individual instance for example: https://github.com/tinkerbell/tink/pull/581

mmlb avatar Feb 01 '22 22:02 mmlb

I think we're good here. please reopen if not.

jacobweinstock avatar Jun 28 '24 00:06 jacobweinstock