DDCToolbox icon indicating copy to clipboard operation
DDCToolbox copied to clipboard

.vdc export broken for some ParametricEQ profiles

Open NipOc opened this issue 5 years ago • 7 comments

Some ParametricEQs profiles, like the one for the Hifiman Deva (wireless), get exported with missing settings and crash the Viper4Android app. DDC-Toolbox

NipOc avatar Jun 04 '20 14:06 NipOc

These NaN values are ~completely normal~ and should be supported by Viper4Android. However, their VDC parser seems to be broken in 2.7.1.6 as the devs forgot to handle number conversion exceptions. The upcoming V4A version has this issue fixed and until then you can ~replace these coefficients with zeroes~. (Related issue #3)

timschneeb avatar Jun 04 '20 17:06 timschneeb

@ThePBone NaN need to be fixed. Wild bandwidth, negative frequency are the only way to get NaN result. We have to replace the SOS with NaN by unity gain [1.0,0,0,0,0] Or replace by a constant gain filter that pole and zero annihilate each other to form constant gain, like this [1.99526231496888,0,-1.99526231496888,0,1].

james34602 avatar Jun 05 '20 00:06 james34602

Oh, alright I didn't know that. So would you rather recommend to replace the affected filter by a unity gain or by a constant gain filter?

timschneeb avatar Jun 05 '20 00:06 timschneeb

right, however before @ThePBone make any fix. Please @NipOc provide the vdcproj file so we can debug, let me evaluate what filter cause NaN first.

james34602 avatar Jun 05 '20 00:06 james34602

It looks like the project wasn't saved correctly, so I included the PrarametricEQ file, too.

HIFIMAN Deva (wireless) ParametricEQ.txt HIFIMAN Deva (wireless) ParametricEQ.vdc.txt HIFIMAN Deva (wireless) ParametricEQ.vdcprj.txt

NipOc avatar Jun 05 '20 01:06 NipOc

About the .vdcprj saving issue:

You're using a nightly build, right? In one of the last commits was a typo breaking the save feature under certain circumstances. The latest nightly build (1.3.91) has this issue fixed -> Direct download link

timschneeb avatar Jun 05 '20 02:06 timschneeb

Thanks, it's working now.

HIFIMAN Deva (wireless) ParametricEQ.vdcprj.txt

NipOc avatar Jun 05 '20 02:06 NipOc