Tim Rogers

Results 164 comments of Tim Rogers

@etnperlong Sorry to hear that you're having issues with proxies in Octokit! Have you tried this without customising `fetch`? I wonder if that could be part of the issue.

@rodumani Sorry to hear you're having issues here! We're working on some changes to the structure of Octokit.js, and it sounds like this might have had unexpected consequences. Could you...

What happens if you remove the comment line from your GraphQL query? Does that fix the issue?

@dcarbone 👋🏻 Would you be up for making a PR to improve the documentation? I'm sure other people will run into issues like this.

@tg44 Do you think it would be enough just to pass the `request` (i.e. `IncomingMessage`) to the event handler as another argument? I think that might be a simpler design...

I like the idea of just passing the request to the event handler - with types, of course ✨ I'm not sure how soon I or someone else at GitHub...

Wonderful! Happy to review 😊

👋 I'm up for picking this up, if that's okay? ❤️

👋🏻 Yep! I think this issue is mostly discussion and decision rather than actually implementation, so I'll share some thoughts here soon.

@gmcgibbon How do you feel about this approach? It allows you to opt-in for faster boot times, whilst not ending up being a breaking change in certain cases.