django-bulma icon indicating copy to clipboard operation
django-bulma copied to clipboard

Remove delete button from general form error

Open raymond-devries opened this issue 4 years ago • 3 comments

Since bulma doesn't ship with javascript included, the delete/close button does not function. On top of this the delete/close will actually submit the form when clicked. This means the button does not only fail to perform its expected behavior, it also has unintended side effects. It's probably best that the button is removed or that a general message header replaces the button.

This pull request just removes the malfunctioning button.

raymond-devries avatar Aug 12 '21 19:08 raymond-devries

Here is a photo of the message with no button. This is what the pull request currently proposes.

image

Here is photo of the message with just "error" in the heading. The pull request could be changed to this if this is more desirable.

image

raymond-devries avatar Aug 12 '21 19:08 raymond-devries

@raymond-devries sorry for getting back that late. Sure, I think we should add the "Error" header instead, could you please update your PR?

timonweb avatar Oct 21 '21 14:10 timonweb

No worries. I can update my PR. Do I need to mark the "Error" string for translation? With a header string that isn't marked for translation it will be impossible for someone to use this error box in an internationalized application.

raymond-devries avatar Oct 27 '21 18:10 raymond-devries