Revise.jl
Revise.jl copied to clipboard
Remove dependency on `Libc.TimeVal` by directly calling `time()` instead
As far as I can tell, this has the exact same functionality but allows Base.Libc to move to timespec internally (and get rid of deprecated unix functionality). Ref https://github.com/JuliaLang/julia/pull/45023. Shouldn't break anything, as this is internal, right?
Sorry for the delay here. I can't find any evidence that it's a bad idea so :shrug:
I'm not sure why the tests didn't run, let's see if a close/reopen triggers them (or at least an approval button).
Looks like the close/reopen worked - are those failures related/benign? They don't seem to occur with code running here..
I'm seeing test failures locally. I will poke at it but it could be a bit, these are never easy to track down. I'd rather wait to merge this until CI is working, this could have subtle errors and the more chances to catch them the better.
I'm beginning to think we need to get more of the interpreter infrastructure into Julia itself...hard to maintain otherwise.
Thank you! I'm not too familiar with the impact a higher precision could have here - naively I didn't think it would impact things, so maybe it "just" uncovers other bugs?
Any update on this?
Maybe rebase this PR against master and see if CI passes ?
nightly failures are expected (https://github.com/timholy/Revise.jl/pull/694).
Let's try this