Revise.jl icon indicating copy to clipboard operation
Revise.jl copied to clipboard

Remove dependency on `Libc.TimeVal` by directly calling `time()` instead

Open Seelengrab opened this issue 3 years ago • 7 comments

As far as I can tell, this has the exact same functionality but allows Base.Libc to move to timespec internally (and get rid of deprecated unix functionality). Ref https://github.com/JuliaLang/julia/pull/45023. Shouldn't break anything, as this is internal, right?

Seelengrab avatar Apr 19 '22 07:04 Seelengrab

Sorry for the delay here. I can't find any evidence that it's a bad idea so :shrug:

I'm not sure why the tests didn't run, let's see if a close/reopen triggers them (or at least an approval button).

timholy avatar Jun 26 '22 20:06 timholy

Looks like the close/reopen worked - are those failures related/benign? They don't seem to occur with code running here..

Seelengrab avatar Jun 27 '22 06:06 Seelengrab

I'm seeing test failures locally. I will poke at it but it could be a bit, these are never easy to track down. I'd rather wait to merge this until CI is working, this could have subtle errors and the more chances to catch them the better.

I'm beginning to think we need to get more of the interpreter infrastructure into Julia itself...hard to maintain otherwise.

timholy avatar Jun 28 '22 12:06 timholy

Thank you! I'm not too familiar with the impact a higher precision could have here - naively I didn't think it would impact things, so maybe it "just" uncovers other bugs?

Seelengrab avatar Jun 28 '22 21:06 Seelengrab

Any update on this?

Seelengrab avatar Aug 06 '22 17:08 Seelengrab

Maybe rebase this PR against master and see if CI passes ?

t-bltg avatar Aug 06 '22 19:08 t-bltg

nightly failures are expected (https://github.com/timholy/Revise.jl/pull/694).

t-bltg avatar Aug 07 '22 16:08 t-bltg

Let's try this

timholy avatar Sep 14 '22 20:09 timholy