forge-externals-plugin icon indicating copy to clipboard operation
forge-externals-plugin copied to clipboard

serialport submodules

Open silveiralsv opened this issue 3 years ago • 4 comments

@timfish

I found an cenario where scoped subdependencies of serialport(Eg: @serialport/parser-byte-length) wasn't included on node_modules after forge package.

Please review the change adding the split case of foundModules so we could publish an fix version.

silveiralsv avatar Feb 22 '22 17:02 silveiralsv

Fix on PR

An alternative until release one version is use patch-package to modify this code:

if (file.startsWith(`/node_modules/${module}`)) {

to:

if (file.startsWith(`/node_modules/${module}`) || file.startsWith(`/node_modules/${module.split('/')[0]}`)) {

silveiralsv avatar Feb 22 '22 17:02 silveiralsv

Does it help if you also add @serialport/parser-byte-length to externals too?

timfish avatar Feb 22 '22 19:02 timfish

@timfish I'm also receiving this same error and adding that to the externals does not help.

john-whiting avatar May 02 '22 03:05 john-whiting

I can also confirm that I tried that work around and it works nicely.

john-whiting avatar May 02 '22 03:05 john-whiting