forge-externals-plugin
forge-externals-plugin copied to clipboard
serialport submodules
@timfish
I found an cenario where scoped subdependencies of serialport(Eg: @serialport/parser-byte-length) wasn't included on node_modules after forge package.
Please review the change adding the split case of foundModules so we could publish an fix version.
Fix on PR
An alternative until release one version is use patch-package to modify this code:
if (file.startsWith(`/node_modules/${module}`)) {
to:
if (file.startsWith(`/node_modules/${module}`) || file.startsWith(`/node_modules/${module.split('/')[0]}`)) {
Does it help if you also add @serialport/parser-byte-length to externals too?
@timfish I'm also receiving this same error and adding that to the externals does not help.
I can also confirm that I tried that work around and it works nicely.