timescaledb-extras icon indicating copy to clipboard operation
timescaledb-extras copied to clipboard

On conflict with conflict target

Open mglonnro opened this issue 4 years ago • 3 comments
trafficstars

Cheers,

I read the earlier discussion about on conflict do update with a missing primary key (gives error). I made this simple change to make this work in my own project. Just a simple transport for whatever conflict target I want to be included in the statement.

What is your thinking about this? I'd be happy to make a pull request unless you're going down some other route to solve the problem.

https://github.com/timescale/timescaledb-extras/commit/dfc98d090099add9faeffafc30763e1b870e18ea

mglonnro avatar Feb 21 '21 07:02 mglonnro

Definitely need to be rectified in master... I'm OK with your solution.

DavidPavlicek avatar Mar 15 '21 13:03 DavidPavlicek

Definitely need to be rectified in master... I'm OK with your solution.

Pull request #18 there now :)

mglonnro avatar Mar 20 '21 06:03 mglonnro

i just ran into this as well, would be great to get #18 merged!

branchvincent avatar Jul 27 '21 18:07 branchvincent