docs icon indicating copy to clipboard operation
docs copied to clipboard

Candlestick tutorial technical check

Open aldia-ercule opened this issue 1 year ago • 6 comments

ran technical check, updated instructions and links accordingly

Description

I ran a technical check on this tutorial and updated outdated instructions and links accordingly. Most of my work revolved around the prerequisite section and how there was no link or instructions on what data to use for the tutorial. As such, I relied on the Twelve Data zip file from the Candlestick tutorial on the live site, where I ran into the issue of the tick data .csv being incomplete and not having values for traded day volume. Because of this I could not run a technical check on the last section of the tutorial.

Links

Fixes #[insert issue link, if any]

Writing help

For information about style and word usage, see the style guide

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • [ ] Is the content technically accurate?
  • [ ] Is the content complete?
  • [ ] Is the content presented in a logical order?
  • [ ] Does the content use appropriate names for features and products?
  • [ ] Does the content provide relevant links to further information?

Documentation team review checklist

  • [ ] Is the content free from typos?
  • [ ] Does the content use plain English?
  • [ ] Does the content contain clear sections for concepts, tasks, and references?
  • [ ] Have any images been uploaded to the correct location, and are resolvable?
  • [ ] If the page index was updated, are redirects required and have they been implemented?
  • [ ] Have you checked the built version of this content?

aldia-ercule avatar Mar 06 '24 22:03 aldia-ercule

@jonatas, can I please ask you to check this tutorial? @aldia-ercule reported that the data is incomplete. Do you know if we have this missing data somewhere else?

contentana avatar Mar 08 '24 15:03 contentana

Hi @aldia-ercule , I see tutorials/OLD_grafana/visualizations/candlestick.md.

Even being OLD, thanks for the fix on the outdated stuff. Not sure if we have any non-OLD correspondent tutorial or that's all.

jonatas avatar Mar 11 '24 20:03 jonatas

hi there @jonatas, would you like me to keep exploring different avenues to finish this technical check then? The tutorial on the live site says the data is sourced from Twelve Data, and I was curious about whether Timescale has a newer asset from them that includes traded day volume as a value?

aldia-ercule avatar Mar 11 '24 23:03 aldia-ercule

Hi, Aldia! If @Jônatas Paganini @.***> can't provide you with a newer asset, let's try to complete the tutorial as best as we can, even if we need to add/remove parts of it. Thanks!

Ana Margarida Tavares (she/her) Sr. Content Marketing Manager | Timescale Timescale.com https://www.timescale.com/

LinkedIn https://www.linkedin.com/in/ana-margarida-tavares-b1228411/ My working hours may be different from your working hours. Please don't feel you need to reply outside your regular work schedule.

On Mon, Mar 11, 2024 at 11:03 PM aldia-ercule @.***> wrote:

hi there @jonatas https://github.com/jonatas, would you like me to keep exploring different avenues to finish this technical check then? The tutorial on the live site says the data is sourced from Twelve Data, and I was curious about whether Timescale has a newer asset from them that includes traded day volume as a value?

— Reply to this email directly, view it on GitHub https://github.com/timescale/docs/pull/3055#issuecomment-1989609136, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2JABB54PKDVKLVSDIPQ4SLYXZA5VAVCNFSM6AAAAABEJ4TQOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBZGYYDSMJTGY . You are receiving this because you modified the open/close state.Message ID: @.***>

contentana avatar Mar 13 '24 10:03 contentana

Hi Aida, feel free to create an API key for twelve data. They have free keys. You can also use other APIs to load more data if you want to go deeper.

jonatas avatar Mar 13 '24 11:03 jonatas

@jonatas I'll look into the API keys, thanks for the tip! @contentana if the API keys don't end up working out, I'll finish up my edits without the day volume portion.

aldia-ercule avatar Mar 13 '24 20:03 aldia-ercule