Tim Mitchell

Results 13 comments of Tim Mitchell

Sorry about that - I was not being careful with my code tidying

Me neither. I couldn't figure it out so I raised in issue upstream https://github.com/kanety/jquery-simple-tree-table/issues/8

It seems neither of us have the energy to make this happen. How about closing this PR?

[logs-20181112-100519.zip](https://github.com/leinardi/mypy-pycharm/files/2569842/logs-20181112-100519.zip)

msgpack.unpack is _really_ slow for large files as it reads 2k chunks by default and appends each one to the result. Supplying a read_size of 100k improves performance considerably

I am running on windows, and yes, I did notice a significant difference.

Hi Burak, I forgot to mention that my payload was 200Mb when I noticed the slowness, so may not be a typical usage issue. Also, having looked at the msgpack...

I found I was using the pure python fall-back version, when I compiled the C-extension it runs speedy as.

Note the change to the suggested fix - the C version of msgpack.unpack reads the entire file and passes it to unpackb.

Please see my changes in the tim-mitchell fork for additional changes and tests.